Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(otel): Don't use scope for otel transaction name #602

Closed
wants to merge 1 commit into from

Conversation

AbhiPrasad
Copy link
Member

Fixes #596

This is a hack - so open to keep iterating on this, but in the spirit of just fixing this asap to ship I opened this PR.

This change makes it so that if there is a span description set, use that as the transaction name.

Nothing should be setting this for transactions, as we don't expose this API anywhere, so we should be safe to only make this work for otel.

Draft for now, thoughts appreciated!

@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.07 🎉

Comparison is base (27e50ad) 78.85% compared to head (bd144f4) 78.93%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #602      +/-   ##
==========================================
+ Coverage   78.85%   78.93%   +0.07%     
==========================================
  Files          38       38              
  Lines        3869     3869              
==========================================
+ Hits         3051     3054       +3     
+ Misses        714      712       -2     
+ Partials      104      103       -1     
Impacted Files Coverage Δ
otel/span_processor.go 94.33% <100.00%> (+2.52%) ⬆️
tracing.go 88.24% <100.00%> (+0.10%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@AbhiPrasad
Copy link
Member Author

Closing because I jumped the gun 😬 - but we'll be chatting about this later today to make:

TRACING API V2 (the better one™️) 🫡

@AbhiPrasad AbhiPrasad closed this Mar 15, 2023
@cleptric cleptric deleted the abhi-transaction-name-works branch September 4, 2023 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OTel Context Missing
1 participant