New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace deprecated ioutil pkg with os & io #454
Conversation
As of Go 1.16, the same functionality is now provided by package io or package os, and those implementations should be preferred in new code. So replacing all usage of ioutil pkg with io & os.
@kamilogorek this PR safe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abhinavnair Would you be so kind as to update the Changelog.md and include a note similar to https://github.com/getsentry/sentry-go/blob/master/CHANGELOG.md#v0120 letting folks know that versions before 1.16 won't work anymore?
It looks like something got stuck in GH actions. @abhinavnair can you push an empty commit to retrigger checks? |
i was just looped in here, and possibly I am being a bit overcautious 😅 . And I'm no expert in Go, we just see some significant number of events coming in for sub 1.16 Go versions. So I am wondering if this breaking change can be based on some version dependency check from the SDK? |
any thoughts on my post above? @kamilogorek maybe we just need to make a decision here on what to do |
Together with @smeubank , we'll follow up on this, respecting our depreciation policy. |
Pull request was closed
As of Go 1.16, the same functionality is now provided by package io or
package os, and those implementations should be preferred in new code.
So replacing all usage of
ioutil
pkg withio
&os
.