Add StripSpanContextKeyFromContext #453
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matches the logic from `TransactionFromContext` and returns nil. This is idiomatic and does what it says on the tin, if the context does not have a span contained within it, I would not expect anything to be returned. An error seems... extra.
StripSpanContextKeyFromContext returns a new context with the parent span removed but critically retaining the parentSpanID, allowing for new transactions to be formed within the same running process while retaining all the current context benefits, including existing sentry context keys (apart from `spanContextKey`) and timeouts etc.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #452 for the
spanFromContextchange, I'm hoping that can be merged before this.SpanFromContextwill allow us to extract the spanid from a context, we can then strip the span from that context (yielding a new context), which can be then used to create a new span with a span option to populate the parentspanid (which remains unpopulated if a parent span doesn't exist).Ultimately this allows us to construct new transactions in-process and keep the existing context chain.