feat: ✨ Added function to continue from trace string #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows users to easily add traces from sources other than http.Request
kamilogorek
reviewed
Apr 27, 2022
Co-authored-by: Kamil Ogórek <kamil.ogorek@gmail.com>
|
Lovely, thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tl;dr: This allows users to easily add traces from sources other than http.Request
Recently ran in to a situation where we want to add tracing between services where not all of them uses HTTP to communicate (in this case, rabbitMQ) so I refactored a bit and added a new exposed function that continues from a trace header.
This does not introduce any breaking changes from what I can see and the tests does of course still pass.