Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: another API like ContinueFromRequest but allow parameter (not http.Request) #387

Closed
yeqown opened this issue Oct 22, 2021 · 2 comments

Comments

@yeqown
Copy link

yeqown commented Oct 22, 2021

Summary

another API like ContinueFromRequest but allow a different parameter (not http.Request)

Motivation

support trace information transfer across process bwtween different protocols

Additional Context

maybe looks like:

func ContinueFromXXXX(trace string) SpanOption {
	return func(s *Span) {
		if trace == "" {
                        return
                 }
		s.updateFromSentryTrace([]byte(trace))
	}
}
@yeqown
Copy link
Author

yeqown commented Oct 22, 2021

For example, in this issue #240:

  • how to extract trace info from request?
  • how to inject trace info into context.Context

@cleptric
Copy link
Member

cleptric commented Oct 30, 2022

Fixed in v0.14.0 via #434

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants