Skip to content

Commit

Permalink
Review feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
cleptric committed Nov 7, 2022
1 parent 565c4a6 commit df61c9f
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion interfaces.go
Expand Up @@ -223,7 +223,7 @@ const (

// SDKMetaData is a struct to stash data which is needed at some point in the SDK's event processing pipeline
// but which shouldn't get send to Sentry.
type SDKMetaData = struct {
type SDKMetaData struct {
DynamicSamplingContextKey DynamicSamplingContext
}

Expand Down
6 changes: 3 additions & 3 deletions tracing.go
Expand Up @@ -230,8 +230,8 @@ func (s *Span) ToSentryTrace() string {
}

func (s *Span) ToBaggage() string {
if dsc := s.dynamicSamplingContext; len(dsc.Entries) > 0 {
return dsc.String()
if len(s.dynamicSamplingContext.Entries) > 0 {
return s.dynamicSamplingContext.String()
}

return ""
Expand Down Expand Up @@ -612,7 +612,7 @@ func ContinueFromRequest(r *http.Request) SpanOption {

// ContinueFromHeaders returns a span option that updates the span to continue
// an existing TraceID and propagates the Dynamic Sampling context.
func ContinueFromHeaders(trace string, baggage string) SpanOption {
func ContinueFromHeaders(trace, baggage string) SpanOption {
return func(s *Span) {
if trace != "" {
s.updateFromSentryTrace([]byte(trace))
Expand Down

0 comments on commit df61c9f

Please sign in to comment.