Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also added
SentrySdk.UnsetTag
, because it feels closely related withSetTag
.Some questions I had while implementing this:
Hub.ConfigureScope
wraps the call toScopeManager.ConfigureScope
in a try/catch, would that be appropriate for these methods too? E.g.PushScope
doesn't use a try/catch.sentry-dotnet/src/Sentry/Internal/Hub.cs
Lines 90 to 100 in aebd6a2
IHasTags
which can set multiple tags at once. Does it make sense to add it toSentrySdk
too?sentry-dotnet/src/Sentry/IHasTags.cs
Line 33 in aebd6a2