-
-
Notifications
You must be signed in to change notification settings - Fork 220
Rename thread pool protocol keys to snake case #1472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename thread pool protocol keys to snake case #1472
Conversation
@bruno-garcia so should these be snake case as well?
|
Either the way we want to show in the UI if not part of the protocol, or snake case and added to develop docs and changes in sentry UI to render nicely. The "UI" culture is a known protocol I believe, just the key there is different because we add two instances. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we have some snapshot or other type of tests to validate this?
Codecov Report
@@ Coverage Diff @@
## main #1472 +/- ##
==========================================
+ Coverage 84.25% 84.26% +0.01%
==========================================
Files 219 219
Lines 7387 7387
Branches 1417 1417
==========================================
+ Hits 6224 6225 +1
Misses 727 727
+ Partials 436 435 -1
Continue to review full report at Codecov.
|
fixes #1471