-
-
Notifications
You must be signed in to change notification settings - Fork 220
feat: EF 6 Query as Span. #1107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1107 +/- ##
==========================================
+ Coverage 82.60% 82.61% +0.01%
==========================================
Files 212 215 +3
Lines 7116 7150 +34
Branches 1401 1407 +6
==========================================
+ Hits 5878 5907 +29
- Misses 804 808 +4
- Partials 434 435 +1
Continue to review full report at Codecov.
|
@bruno-garcia This integration will work on .NET Standard 2.1. |
…otnet into feat/ef-query
|
We need to make this work with 4.6.1 so if we need to bump the min EF version then lets do that 6.2.0 is from 2017 so definitely not a problem: https://www.nuget.org/packages/EntityFramework/6.2.0 |
That's great cus that's what I did :D (Increased EF version to 6.2.0 on NET461) |
src/Sentry.EntityFramework/Internals/Extensions/DbCommandInterceptionContextExtensions.cs
Outdated
Show resolved
Hide resolved
Fix requested changes.
Fix requested changes and fix test. Updated verify check.
This PR allows the SDK to automatically create Spans for operations related to Entity Framework.
For keeping the pattern with DiagnosticSource, I have edited some names for better understanding:
ReaderExecuting will result on a span with operation "db.query"
ScalarExecutingwill result on a span with operation "db.query-scalar"
NonQueryExecutingwill result on a span with operation "db.execute"
Samples:
https://sentry.io/organizations/sentry-sdks/discover/sentry-dotnet:a6e624483558476bbf4e3a8ec3c1f477/?field=title&field=event.type&field=project&field=user.display&field=timestamp&name=All+Events&query=&sort=-timestamp&statsPeriod=1h&user=314270&yAxis=count%28%29
https://sentry.io/organizations/sentry-sdks/discover/sentry-dotnet:a7faaa0dde1c43fa95948bda62d3606f/?field=title&field=event.type&field=project&field=user.display&field=timestamp&name=All+Events&query=&sort=-timestamp&statsPeriod=1h&user=314270&yAxis=count%28%29
https://sentry.io/organizations/sentry-sdks/discover/sentry-dotnet:72a5884526174201aa0575a01bb780a1/?field=title&field=event.type&field=project&field=user.display&field=timestamp&name=All+Events&query=&sort=-timestamp&statsPeriod=1h&user=314270&yAxis=count%28%29
Close #1173.