Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Clarification around size limits and stats #9911

Merged
merged 9 commits into from May 11, 2024

Conversation

kahest
Copy link
Member

@kahest kahest commented May 3, 2024

To clarify that events dropped due to size limits are part of the Usage Stats "Dropped" category:

  • adds note with link to usage stats in the size limits docs
  • adds size limits as reason for dropped events on usage stats docs

TBD: The size limits docs are currently hard to find (see e.g. getsentry/sentry#70342). I think it'd be reasonable to maybe add a page directly under the "Data Management" tree? Happy to add this to the PR if we agree on something

Copy link

vercel bot commented May 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 11, 2024 0:25am

Copy link

codecov bot commented May 3, 2024

Bundle Report

Changes will increase total bundle size by 168 bytes ⬆️

Bundle name Size Change
sentry-docs-server 7.42MB 177 bytes ⬆️
sentry-docs-edge-server 456.19kB 3 bytes ⬇️
sentry-docs-client 6.16MB 6 bytes ⬇️

@vivianyentran
Copy link
Contributor

I think adding a page on size limits would be great!

@kahest
Copy link
Member Author

kahest commented May 6, 2024

@vivianyentran I split out the a size limits page and added it under Data Management - wdyt?

@kahest kahest requested a review from vivianyentran May 8, 2024 10:53
@kahest
Copy link
Member Author

kahest commented May 8, 2024

@vivianyentran pls give this another quick look - I merged in the redesign, recreated the new page under the new concepts section and rewired the links

Added some headings to make this skimmable
@vivianyentran
Copy link
Contributor

Made some edits directly! I'll go ahead and merge this now

@vivianyentran vivianyentran enabled auto-merge (squash) May 10, 2024 23:57
@vivianyentran vivianyentran merged commit f9bd16f into master May 11, 2024
6 checks passed
@vivianyentran vivianyentran deleted the kahest/size-limit-stats branch May 11, 2024 00:25
antonpirker pushed a commit that referenced this pull request May 14, 2024
* adds link to stats, adds size limits drop reason

* splits out size limits page under data mgmt

* temp remove new file for merge

* merges redesign & rewires/recreates content update

* Update size-limits.mdx

Added some headings to make this skimmable

* Update docs/product/stats/index.mdx

* Update size-limits.mdx

* Update index.mdx

fix link

---------

Co-authored-by: vivianyentran <20403606+vivianyentran@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants