Add documentation for React Router 6.4 support. #5822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@onurtemizkan is attempting to deploy a commit to the Sentry Team on Vercel. A member of the Team first needs to authorize it. |
onurtemizkan
requested review from
AbhiPrasad and
imatwawana
and removed request for
AbhiPrasad
AbhiPrasad
reviewed
Nov 21, 2022
| @@ -34,6 +34,51 @@ Make sure `Sentry.reactRouterV6Instrumentation` is initialized by your `Sentry.i | |||
|
|
|||
| </Alert> | |||
|
|
|||
| ### Usage with React Router 6.4 Data API | |||
| _(Available in version 7.21.0 and above)_ | |||
There was a problem hiding this comment.
The initialization part above is common for all 6.x versions (reactRouterV6Instrumentation(...)). Will have to repeat that info if we do that?
There was a problem hiding this comment.
Ah fair, than we can keep it here.
|
|
||
| <Alert level="warning" title="Note"> | ||
|
|
||
| [`createHashRouter`](https://reactrouter.com/en/main/routers/create-hash-router) is not yet supported by Sentry. On the other hand [`createMemoryRouter`](https://reactrouter.com/en/main/routers/create-memory-router) can be instrumented using `wrapCreateBrowserRouter` function. |
There was a problem hiding this comment.
we should create a GH issue about createHashRouter that we can link folks to here.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
lizokm
approved these changes
Nov 22, 2022
src/platforms/javascript/guides/react/configuration/integrations/react-router.mdx
Outdated
Show resolved
Hide resolved
src/platforms/javascript/guides/react/configuration/integrations/react-router.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Liza Mock <lizka920@gmail.com>
AbhiPrasad
approved these changes
Nov 22, 2022
There was a problem hiding this comment.
Released in 7.21.0 so merging https://github.com/getsentry/sentry-javascript/blob/master/CHANGELOG.md#7210
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documents: getsentry/sentry-javascript#6172
TODO: Update the version