Add OpenTelemetry Node SDK docs #5760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Moving this to draft because it may be blocked by @onurtemizkan's work in #5710. |
imatwawana
reviewed
Nov 10, 2022
src/platforms/common/performance/instrumentation/opentelemetry.mdx
Outdated
Show resolved
Hide resolved
src/platforms/common/performance/instrumentation/opentelemetry.mdx
Outdated
Show resolved
Hide resolved
src/platform-includes/performance/opentelemetry-install/node.mdx
Outdated
Show resolved
Hide resolved
src/platforms/common/performance/instrumentation/opentelemetry.mdx
Outdated
Show resolved
Hide resolved
….mdx Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
….mdx Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
mydea
force-pushed
the
abhi-otel-node-docs
branch
from
f63ab9b
to
3e2b794
Compare
mydea
approved these changes
Nov 15, 2022
imatwawana
approved these changes
Nov 15, 2022
Comment on lines
+9
to
+16
| <Note> | ||
|
|
||
| Note that @sentry/opentelemetry-node depends on the following peer dependencies: | ||
|
|
||
| - @opentelemetry/api, version 1.0.0 or greater | ||
| - @opentelemetry/sdk-trace-base, version 1.0.0 or greater, or a package that implements it, like @opentelemetry/sdk-node | ||
|
|
||
| </Note> |
There was a problem hiding this comment.
Should the note about dependencies come before the install step?
There was a problem hiding this comment.
personally I find it better placed below (so the flow: this is how to install sentry. But make sure that you also have these dependencies installed). But we can of course still adjust this later as well! :)
Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly based on the README here: https://www.npmjs.com/package/@sentry/opentelemetry-node
Initial Context: getsentry/sentry#40712
Node SDK work: getsentry/sentry-javascript#6000