New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add node and browser sdk transport option docs #5740
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @AbhiPrasad
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found some weirdness with the way the platformsection is working in the preview and left a question.
|
||
- `headers`: An object containing headers to be sent with every request. | ||
- `proxy`: A proxy used for outbound requests. Can be http or https. | ||
- `caCerts`: A single or list of a path to a file or directory, or a buffer of CA certificates |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bit unclear. A single cert or a single path?
- `caCerts`: A single or list of a path to a file or directory, or a buffer of CA certificates | |
- `caCerts`: A single or list of a path to a file or directory, or a buffer of CA certificates |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it can be:
- a path to a CA certificate
- a list of paths to a CA certificate
- a buffer of CA certificates
Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Preview looks good! I just made a small tweak, but otherwise LGTM!
Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
Only can get merged once getsentry/sentry-javascript#6161 is released.
Add documentation for Node Transport options.