Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(vue): Add vue-router version support information #5662

Merged
merged 2 commits into from Oct 18, 2022

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Oct 18, 2022

This adds a note on which vue-router versions are supported by our vue routing instrumentation. Also did some minor cleanup of the code example as it contained some unnecessary lines.

ref: getsentry/sentry-javascript#5910

@Lms24 Lms24 requested a review from AbhiPrasad October 18, 2022 13:57
@vercel
Copy link

vercel bot commented Oct 18, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
sentry-docs ✅ Ready (Inspect) Visit Preview Oct 18, 2022 at 3:45PM (UTC)

Copy link
Contributor

@imatwawana imatwawana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple style edits

Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
@Lms24 Lms24 enabled auto-merge (squash) October 18, 2022 15:29
@Lms24 Lms24 merged commit 8c2c2c7 into master Oct 18, 2022
@Lms24 Lms24 deleted the lms-vue-router-support branch October 18, 2022 15:40
@github-actions github-actions bot locked and limited conversation to collaborators Nov 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants