Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Update BrowserTracing options description #5605

Merged
merged 1 commit into from Oct 6, 2022

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Oct 5, 2022

Noticed a few inconsistencies between docs and SDK code while working on #5606: This PR brings the JS SDK BrowserTracing integration options up to date with the currently available options:

  • add finalTimeout option introduced in v7
  • remove maxTransactionDuration option dropped in v7
  • improve idleTimeout description

@vercel
Copy link

vercel bot commented Oct 5, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
sentry-docs ✅ Ready (Inspect) Visit Preview Oct 6, 2022 at 1:07PM (UTC)

@Lms24 Lms24 changed the title ref: Update BrowserTracing options description ref: Update BrowserTracing options description Oct 5, 2022
Copy link
Contributor

@imatwawana imatwawana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one wording edit but otherwise LGTM!

@imatwawana
Copy link
Contributor

Just one wording edit but otherwise LGTM!

I deleted my suggestion as I see the same language is used elsewhere. No edits!

@Lms24 Lms24 merged commit d20482c into master Oct 6, 2022
@Lms24 Lms24 deleted the lms-update-browsertracing-options branch October 6, 2022 16:06
lforst pushed a commit that referenced this pull request Oct 10, 2022
Bring the JS SDK `BrowserTracing` integration options up to date with the currently available options:

* add `finalTimeout` option introduced in v7
* remove `maxTransactionDuration` option dropped in v7
* improve `idleTimeout` description
@github-actions github-actions bot locked and limited conversation to collaborators Oct 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants