Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(php): Adjust docs for Laravel DS #5601

Merged
merged 9 commits into from Oct 19, 2022
Merged

feat(php): Adjust docs for Laravel DS #5601

merged 9 commits into from Oct 19, 2022

Conversation

cleptric
Copy link
Member

@cleptric cleptric commented Oct 5, 2022

@cleptric cleptric self-assigned this Oct 5, 2022
@cleptric
Copy link
Member Author

cleptric commented Oct 5, 2022

@stayallive Can you take a look please 🙂

@vercel
Copy link

vercel bot commented Oct 5, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
sentry-docs ✅ Ready (Inspect) Visit Preview Oct 11, 2022 at 0:37AM (UTC)

imatwawana
imatwawana reviewed Oct 5, 2022
View reviewed changes
Copy link
Contributor

@imatwawana imatwawana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some parts of this that aren't clear. I'm not sure what components (using the term generically here) are taking which actions. I've suggested some edits, but I don't know if they change the meaning. Ping me if you want to discuss.

src/platforms/php/guides/laravel/performance/connect-services.mdx Outdated Show resolved Hide resolved
src/platforms/php/guides/laravel/performance/connect-services.mdx Outdated Show resolved Hide resolved
cleptric and others added 3 commits October 5, 2022 20:07
@cleptric @imatwawana
Update src/platforms/php/guides/laravel/performance/connect-services.mdx
40dd28f 
Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
@cleptric @imatwawana
Update src/platforms/php/guides/laravel/performance/connect-services.mdx
9541e28 
Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
@cleptric
Merge branch 'master' into dynamic-sampling
af7280f
@cleptric cleptric marked this pull request as draft October 5, 2022 18:18
@cleptric
Copy link
Member Author

cleptric commented Oct 5, 2022

@imatwawana Thanks for your help! Just making this a draft again, as we still haven't shipped DS for Laravel just yet.

@cleptric
Update Laravel version
cf090f8
@cleptric
Merge branch 'master' into dynamic-sampling
ec2dd9c 
# Conflicts:
#	src/includes/sampling-supported-sdks.mdx
@cleptric cleptric mentioned this pull request Oct 11, 2022
Merged
19 tasks
@cleptric cleptric marked this pull request as ready for review October 18, 2022 12:23
@cleptric cleptric merged commit 8940f56 into master Oct 19, 2022
@cleptric cleptric deleted the dynamic-sampling branch October 19, 2022 08:51
@github-actions github-actions bot locked and limited conversation to collaborators Nov 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@imatwawana imatwawana imatwawana left review comments

Assignees

@cleptric cleptric

Labels
Platform: PHP Team: Web Backend SDKs team-web-sdk-backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cleptric @imatwawana