Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

android apollo3 integration #5289

Merged
merged 14 commits into from
Aug 8, 2022
Merged

Conversation

lbloder
Copy link
Contributor

@lbloder lbloder commented Jul 13, 2022

@vercel
Copy link

vercel bot commented Jul 13, 2022

@lbloder is attempting to deploy a commit to the Sentry Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Jul 13, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
sentry-docs ✅ Ready (Inspect) Visit Preview Jul 14, 2022 at 2:17PM (UTC)

Copy link
Contributor

@imatwawana imatwawana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some style and wording edits. Some of the ones I made in the Android file should be replicated in the Java file.

lbloder and others added 5 commits July 14, 2022 14:52
Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>

ApolloClient apollo = ApolloBuilderExtensionsKt.sentryTracing(new ApolloClient.Builder())
.serverUrl("https://your-api-host/")
.sentryTracing()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this redundant? It isn't included in the example further down under ## Modify or Drop Spans


ApolloClient apollo = ApolloBuilderExtensionsKt.sentryTracing(new ApolloClient.Builder())
.serverUrl("https://your-api-host/")
.sentryTracing()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

Copy link
Member

@adinauer adinauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, some minor changes I'd like to see. Approving now to not have you blocked here whilie I'm gone. Please fix before merging.

@lbloder lbloder requested a review from a team as a code owner August 5, 2022 12:34
@bruno-garcia
Copy link
Member

@adinauer contractors don't have permission to merge docs, so it's up to us to do it 👌

@bruno-garcia bruno-garcia changed the title Feat/apollo3 android apollo3 integration Aug 8, 2022
@bruno-garcia bruno-garcia merged commit aa651c3 into getsentry:master Aug 8, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants