Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Scope#clone calls the Native bridges again via the scopeObserver #959

Merged
merged 6 commits into from Jul 25, 2022

Conversation

denrase
Copy link
Collaborator

@denrase denrase commented Jul 25, 2022

📜 Description

Closes #926

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2022

Codecov Report

Merging #959 (0f1cc2d) into main (7011abe) will decrease coverage by 0.02%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main     #959      +/-   ##
==========================================
- Coverage   89.52%   89.49%   -0.03%     
==========================================
  Files         105      105              
  Lines        3292     3303      +11     
==========================================
+ Hits         2947     2956       +9     
- Misses        345      347       +2     
Impacted Files Coverage Δ
dart/lib/src/hub_adapter.dart 10.52% <0.00%> (-0.29%) ⬇️
dart/lib/src/noop_hub.dart 20.68% <ø> (ø)
dart/lib/src/sentry.dart 84.72% <0.00%> (ø)
dart/lib/src/hub.dart 80.48% <33.33%> (ø)
dart/lib/src/scope.dart 95.05% <86.95%> (-0.30%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7011abe...0f1cc2d. Read the comment docs.

@denrase denrase marked this pull request as ready for review July 25, 2022 12:24
@marandaneto
Copy link
Contributor

@denrase did that cause duplicated breadcrumbs or is it still just an improvement?

@denrase
Copy link
Collaborator Author

denrase commented Jul 25, 2022

@marandaneto Did not try to reproduce duplication here. Basically i assumed that calling the observers is unwanted behaviour as described in the issue and therefore marked this as fix.

@marandaneto marandaneto merged commit 6c06153 into main Jul 25, 2022
@marandaneto marandaneto deleted the fix/duplicated-breadcrumbs-clone branch July 25, 2022 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scope#clone calls the Native bridges again via the scopeObserver
3 participants