Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Breadcrumbs "Concurrent Modification" #948

Merged
merged 10 commits into from Jul 21, 2022

Conversation

denrase
Copy link
Collaborator

@denrase denrase commented Jul 18, 2022

📜 Description

Closes #941

💚 How did you test it?

Ran unit tests.

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

dart/lib/src/scope.dart Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2022

Codecov Report

Merging #948 (a67dbad) into main (5a35e4a) will increase coverage by 0.12%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #948      +/-   ##
==========================================
+ Coverage   89.81%   89.94%   +0.12%     
==========================================
  Files         104        9      -95     
  Lines        3211      169    -3042     
==========================================
- Hits         2884      152    -2732     
+ Misses        327       17     -310     
Impacted Files Coverage Δ
dart/lib/src/scope.dart
dart/lib/src/protocol/sentry_request.dart
dart/lib/src/protocol/sentry_id.dart
dart/lib/src/sentry_envelope.dart
...ib/src/environment/_web_environment_variables.dart
dart/lib/src/protocol/sentry_gpu.dart
...event_processor/deduplication_event_processor.dart
dart/lib/src/protocol/sentry_stack_trace.dart
dart/lib/src/sentry_traces_sampler.dart
dart/lib/src/http_client/tracing_client.dart
... and 85 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a35e4a...a67dbad. Read the comment docs.

@denrase denrase marked this pull request as ready for review July 20, 2022 07:33
@marandaneto marandaneto enabled auto-merge (squash) July 21, 2022 06:05
@marandaneto marandaneto merged commit 5fff088 into main Jul 21, 2022
@marandaneto marandaneto deleted the fix/breadcrumbs-concurrent-modification branch July 21, 2022 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Concurrent modification" on ListQueue<Breadcrumb> in 6.6.3
4 participants