Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add http response to event #934

Merged
merged 8 commits into from Jul 25, 2022

Conversation

ueman
Copy link
Collaborator

@ueman ueman commented Jul 7, 2022

馃摐 Description

This PR adds the http response to an event.
See https://sentry.io/organizations/sentry-sdks/issues/3405926130/events/eaa5a7d9bd284b64ab3acd5238c61038/?project=5428562 for an example event.

Depends on #933

馃挕 Motivation and Context

Partially addresses #624.
There's also some more context in #933 and kuhnroyal#1 (comment).

Also see getsentry/develop#401 for the initial idea.

馃挌 How did you test it?

new tests

馃摑 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

馃敭 Next steps

@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2022

Codecov Report

Merging #934 (d8f6268) into main (982893c) will decrease coverage by 0.29%.
The diff coverage is 78.65%.

@@            Coverage Diff             @@
##             main     #934      +/-   ##
==========================================
- Coverage   89.81%   89.52%   -0.30%     
==========================================
  Files         104      105       +1     
  Lines        3212     3292      +80     
==========================================
+ Hits         2885     2947      +62     
- Misses        327      345      +18     
Impacted Files Coverage 螖
dart/lib/src/protocol/contexts.dart 90.15% <54.54%> (-3.24%) 猬囷笍
dart/lib/src/protocol/max_body_size.dart 58.33% <58.33%> (酶)
dart/lib/src/protocol/sentry_response.dart 80.00% <80.00%> (酶)
dio/lib/src/dio_event_processor.dart 95.58% <95.83%> (+2.10%) 猬嗭笍
dio/lib/src/sentry_dio_extension.dart 83.33% <100.00%> (+1.51%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 982893c...d8f6268. Read the comment docs.

@marandaneto
Copy link
Contributor

@ueman Tests unless you are ok with this being accidentally reverted :P Said once a wise man.

@ueman
Copy link
Collaborator Author

ueman commented Jul 7, 2022

@ueman Tests unless you are ok with this being accidentally reverted :P Said once a wise man.

Yeeees, I just wanted to get some early feedback :D

Also cc @kuhnroyal, I think you're probably interested in this, too.

@kuhnroyal
Copy link
Contributor

Hope I can find some time tomorrow to check it out.

@kuhnroyal
Copy link
Contributor

Looks good to me, ran this and have a nice new context in Sentry :)

@marandaneto
Copy link
Contributor

@ueman thanks for doing this.
If we add tests + changelog, we are ready to merge and ship it.

@ueman ueman marked this pull request as ready for review July 24, 2022 09:39
@ueman ueman requested a review from brustolin as a code owner July 24, 2022 09:39
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Manoel Aranda Neto <5731772+marandaneto@users.noreply.github.com>
@marandaneto marandaneto merged commit 94daf24 into getsentry:main Jul 25, 2022
@marandaneto
Copy link
Contributor

Thanks @ueman as always.

@ueman ueman deleted the feature/dio-response branch July 25, 2022 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants