Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scope#setContexts pasing a List value would't not work #932

Merged
merged 7 commits into from Jul 27, 2022

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Jul 5, 2022

馃摐 Description

Scope#setContexts pasing a List value would't not work

馃挕 Motivation and Context

#903

馃挌 How did you test it?

馃摑 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

馃敭 Next steps

@marandaneto marandaneto marked this pull request as draft July 5, 2022 11:26
@marandaneto marandaneto marked this pull request as ready for review July 26, 2022 13:46
@marandaneto
Copy link
Contributor Author

@brustolin ready to be reviewed.

Copy link
Collaborator

@brustolin brustolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #932 (aadd669) into main (53b6921) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #932      +/-   ##
==========================================
+ Coverage   89.49%   89.51%   +0.01%     
==========================================
  Files         105      105              
  Lines        3303     3308       +5     
==========================================
+ Hits         2956     2961       +5     
  Misses        347      347              
Impacted Files Coverage 螖
dart/lib/src/scope.dart 95.18% <100.00%> (+0.13%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 53b6921...aadd669. Read the comment docs.

@marandaneto marandaneto merged commit 004b398 into main Jul 27, 2022
@marandaneto marandaneto deleted the fix/context-list branch July 27, 2022 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants