New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Mobile Vitals - Native Frames #772
feat: Mobile Vitals - Native Frames #772
Conversation
Codecov Report
@@ Coverage Diff @@
## feat/mobile-vitals #772 +/- ##
======================================================
+ Coverage 89.47% 90.33% +0.85%
======================================================
Files 110 22 -88
Lines 3469 621 -2848
======================================================
- Hits 3104 561 -2543
+ Misses 365 60 -305
Continue to review full report at Codecov.
|
flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@denrase LGTM, left just a comment tho, https://github.com/getsentry/sentry-dart/pull/772/files#r828893553
@brustolin please double-check :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
📜 Description
Sentry navigator will fetch native frames over native channel and append to
SentryTransaction
for transaction created automatically between navigation.Introduce
onFinish
callback when starting transactions.Introduce
enableAutoPerformanceTracking
flag in flutter options.Bump
sentry-android
to 5.6.3💡 Motivation and Context
Implement native frame tracking of mobile vitals.
💚 How did you test it?
📝 Checklist
🔮 Next steps
More tests!