Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Mobile Vitals - Native Frames #772

Merged
merged 102 commits into from Mar 17, 2022

Conversation

denrase
Copy link
Collaborator

@denrase denrase commented Feb 24, 2022

📜 Description

  • Sentry navigator will fetch native frames over native channel and append to SentryTransaction for transaction created automatically between navigation.

  • Introduce onFinish callback when starting transactions.

  • Introduce enableAutoPerformanceTracking flag in flutter options.

  • Bump sentry-android to 5.6.3

💡 Motivation and Context

Implement native frame tracking of mobile vitals.

💚 How did you test it?

  • Ran iOS/Android example application.
  • Unit tests.

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

More tests!

@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2022

Codecov Report

Merging #772 (41590bf) into feat/mobile-vitals (29f47ff) will increase coverage by 0.85%.
The diff coverage is 79.71%.

@@                  Coverage Diff                   @@
##           feat/mobile-vitals     #772      +/-   ##
======================================================
+ Coverage               89.47%   90.33%   +0.85%     
======================================================
  Files                     110       22      -88     
  Lines                    3469      621    -2848     
======================================================
- Hits                     3104      561    -2543     
+ Misses                    365       60     -305     
Impacted Files Coverage Δ
flutter/lib/src/sentry_flutter_options.dart 72.72% <ø> (ø)
.../lib/src/navigation/sentry_navigator_observer.dart 85.89% <23.07%> (-12.59%) ⬇️
...src/integrations/native_app_start_integration.dart 77.77% <75.00%> (ø)
flutter/lib/src/sentry_flutter.dart 96.00% <83.33%> (+0.16%) ⬆️
flutter/lib/src/sentry_native_channel.dart 92.00% <92.00%> (ø)
...nt_processor/native_app_start_event_processor.dart 92.30% <100.00%> (-1.45%) ⬇️
flutter/lib/src/sentry_native.dart 100.00% <100.00%> (ø)
dart/lib/src/hub.dart
dart/lib/src/hub_adapter.dart
dart/lib/src/noop_hub.dart
... and 85 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29f47ff...41590bf. Read the comment docs.

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@denrase LGTM, left just a comment tho, https://github.com/getsentry/sentry-dart/pull/772/files#r828893553
@brustolin please double-check :)

@denrase denrase mentioned this pull request Mar 17, 2022
7 tasks
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@brustolin brustolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@denrase denrase changed the title Mobile Vitals: Native Frames feat: Mobile Vitals - Native Frames Mar 17, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 17, 2022

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 6a764a0

@marandaneto marandaneto merged commit fc56d22 into feat/mobile-vitals Mar 17, 2022
@marandaneto marandaneto deleted the feat/mobile-vitial-native-frames branch March 17, 2022 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants