Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture Future errors for Flutter Web automatically #1152

Merged
merged 4 commits into from Nov 28, 2022
Merged

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Nov 25, 2022

馃摐 Description

Capture Future errors for Flutter Web automatically

馃挕 Motivation and Context

flutter/flutter#100277 (comment)

馃挌 How did you test it?

Running Flutter Web and non-Web, throwing Future errors, and checking the error handlers.

馃摑 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

馃敭 Next steps

@@ -60,11 +60,6 @@ class FlutterErrorIntegration extends Integration<SentryFlutterOptions> {
final mechanism = Mechanism(
type: 'FlutterError',
handled: true,
data: {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really needed anymore, people are used to scrolling down and reading all the available context.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 25, 2022

Android Performance metrics 馃殌

Plain With Sentry Diff
Startup time 321.51 ms 371.43 ms 49.92 ms
Size 5.94 MiB 6.96 MiB 1.02 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
559d28f 302.35 ms 339.53 ms 37.18 ms
453e1bc 320.41 ms 372.73 ms 52.32 ms
0db91cc 327.85 ms 387.31 ms 59.46 ms
72dfc83 298.62 ms 340.14 ms 41.52 ms
abcdba3 354.68 ms 399.04 ms 44.36 ms
633cf2e 289.36 ms 340.38 ms 51.02 ms
613760b 373.42 ms 399.33 ms 25.92 ms
f4cc744 349.53 ms 394.68 ms 45.15 ms
870f5eb 329.45 ms 369.29 ms 39.84 ms
379d7a8 327.10 ms 355.39 ms 28.29 ms

App size

Revision Plain With Sentry Diff
559d28f 5.94 MiB 6.92 MiB 1001.70 KiB
453e1bc 5.94 MiB 6.95 MiB 1.01 MiB
0db91cc 5.94 MiB 6.95 MiB 1.01 MiB
72dfc83 5.94 MiB 6.92 MiB 1001.71 KiB
abcdba3 5.94 MiB 6.95 MiB 1.01 MiB
633cf2e 5.94 MiB 6.92 MiB 1001.53 KiB
613760b 5.94 MiB 6.92 MiB 1005.98 KiB
f4cc744 5.94 MiB 6.95 MiB 1.01 MiB
870f5eb 5.94 MiB 6.92 MiB 1005.77 KiB
379d7a8 5.94 MiB 6.95 MiB 1.01 MiB

Previous results on branch: fix/future-web

Startup times

Revision Plain With Sentry Diff
4e40541 287.58 ms 337.76 ms 50.17 ms

App size

Revision Plain With Sentry Diff
4e40541 5.94 MiB 6.96 MiB 1.02 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Nov 25, 2022

iOS Performance metrics 馃殌

Plain With Sentry Diff
Startup time 1265.22 ms 1281.06 ms 15.84 ms
Size 8.16 MiB 9.17 MiB 1.01 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
49a149b 1296.47 ms 1320.20 ms 23.73 ms
f922f8f 1249.53 ms 1266.51 ms 16.98 ms
3e5ee37 1248.25 ms 1265.38 ms 17.13 ms
aed5947 1268.67 ms 1281.10 ms 12.43 ms
f4cc744 1274.57 ms 1290.79 ms 16.22 ms
3e9fb0e 1262.49 ms 1280.65 ms 18.16 ms
633cf2e 1257.96 ms 1275.73 ms 17.77 ms
abcdba3 1257.31 ms 1283.49 ms 26.18 ms
48e79fd 1282.96 ms 1296.12 ms 13.17 ms
a609134 1254.50 ms 1265.08 ms 10.58 ms

App size

Revision Plain With Sentry Diff
49a149b 8.15 MiB 9.12 MiB 986.26 KiB
f922f8f 8.15 MiB 9.13 MiB 1003.20 KiB
3e5ee37 8.15 MiB 9.12 MiB 986.23 KiB
aed5947 8.16 MiB 9.17 MiB 1.01 MiB
f4cc744 8.16 MiB 9.16 MiB 1.01 MiB
3e9fb0e 8.15 MiB 9.12 MiB 989.77 KiB
633cf2e 8.15 MiB 9.12 MiB 986.26 KiB
abcdba3 8.15 MiB 9.12 MiB 989.76 KiB
48e79fd 8.16 MiB 9.15 MiB 1021.87 KiB
a609134 8.16 MiB 9.16 MiB 1.01 MiB

Previous results on branch: fix/future-web

Startup times

Revision Plain With Sentry Diff
4e40541 1261.43 ms 1268.12 ms 6.69 ms

App size

Revision Plain With Sentry Diff
4e40541 8.16 MiB 9.17 MiB 1.01 MiB

@marandaneto
Copy link
Contributor Author

@ueman are you aware of this problem?
@denrase do you remember if you tested the new error handler on Web?

@marandaneto
Copy link
Contributor Author

@krystofwoldrich or @brustolin would love a review here.

Copy link
Collaborator

@brustolin brustolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marandaneto marandaneto merged commit 691aa3b into main Nov 28, 2022
@marandaneto marandaneto deleted the fix/future-web branch November 28, 2022 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants