Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not attach headers if Span is NoOp #1143

Merged
merged 3 commits into from Nov 18, 2022

Conversation

marandaneto
Copy link
Contributor

📜 Description

Do not attach headers if Span is NoOp

💡 Motivation and Context

getsentry/sentry-java#2376

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

Copy link
Collaborator

@brustolin brustolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2022

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 309.54 ms 351.08 ms 41.54 ms
Size 5.94 MiB 6.95 MiB 1.01 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
eb1a7c1 332.98 ms 381.55 ms 48.57 ms
613760b 373.42 ms 399.33 ms 25.92 ms
0db91cc 327.85 ms 387.31 ms 59.46 ms
379d7a8 327.10 ms 355.39 ms 28.29 ms
3e5ee37 317.56 ms 366.84 ms 49.28 ms
870f5eb 329.45 ms 369.29 ms 39.84 ms
abcdba3 354.68 ms 399.04 ms 44.36 ms
9c5aec6 287.33 ms 320.94 ms 33.61 ms
21845e2 345.08 ms 382.82 ms 37.74 ms
453e1bc 320.41 ms 372.73 ms 52.32 ms

App size

Revision Plain With Sentry Diff
eb1a7c1 5.94 MiB 6.92 MiB 1005.76 KiB
613760b 5.94 MiB 6.92 MiB 1005.98 KiB
0db91cc 5.94 MiB 6.95 MiB 1.01 MiB
379d7a8 5.94 MiB 6.95 MiB 1.01 MiB
3e5ee37 5.94 MiB 6.92 MiB 1001.19 KiB
870f5eb 5.94 MiB 6.92 MiB 1005.77 KiB
abcdba3 5.94 MiB 6.95 MiB 1.01 MiB
9c5aec6 5.94 MiB 6.92 MiB 1001.61 KiB
21845e2 5.94 MiB 6.92 MiB 1003.77 KiB
453e1bc 5.94 MiB 6.95 MiB 1.01 MiB

@marandaneto marandaneto enabled auto-merge (squash) November 18, 2022 09:12
@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2022

Codecov Report

Base: 91.39% // Head: 91.44% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (af6437f) compared to base (ccc09e4).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1143      +/-   ##
==========================================
+ Coverage   91.39%   91.44%   +0.04%     
==========================================
  Files           9        9              
  Lines         186      187       +1     
==========================================
+ Hits          170      171       +1     
  Misses         16       16              
Impacted Files Coverage Δ
dio/lib/src/tracing_client_adapter.dart 85.71% <100.00%> (+0.71%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@marandaneto marandaneto merged commit 6d7a391 into main Nov 18, 2022
@marandaneto marandaneto deleted the fix/dont-attach-noopspan-headers branch November 18, 2022 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants