Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new constructor which respects Frame Tracking feature flag #1087

Conversation

markushi
Copy link
Member

📜 Description

Frame Tracking can be enabled/disabled in future, this PR adapts the necessary calls into the Android SDK.

💡 Motivation and Context

Related Android PR: getsentry/sentry-java#2314
getsentry/sentry-java#2314 (comment)

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes
  • Android SDK is released (version TBD)
  • New Android SDK is used

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2022

Fails
🚫 Please consider adding a changelog entry for the next release.
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Use new constructor which respects Frame Tracking feature flag ([#1087](https://github.com/getsentry/sentry-dart/pull/1087))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 710308a

@marandaneto
Copy link
Contributor

Thanks @markushi
You can add ignore changelog to the description since its not an user-facing change, also, we have to wait the release.

@github-actions
Copy link
Contributor

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1264.71 ms 1290.63 ms 25.92 ms
Size 8.15 MiB 9.13 MiB 1000.40 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
21845e2 1279.37 ms 1298.81 ms 19.45 ms
ef2f368 1259.12 ms 1277.04 ms 17.92 ms
6d317ea 1277.27 ms 1287.47 ms 10.20 ms
1c6eb5b 1277.85 ms 1285.71 ms 7.86 ms
322aa66 1251.68 ms 1275.52 ms 23.84 ms
9c5aec6 1266.51 ms 1274.65 ms 8.14 ms
56810ff 1267.59 ms 1293.48 ms 25.89 ms
eecbbca 1264.90 ms 1286.33 ms 21.43 ms
af2d175 1280.37 ms 1282.24 ms 1.88 ms
3e5ee37 1248.25 ms 1265.38 ms 17.13 ms

App size

Revision Plain With Sentry Diff
21845e2 8.15 MiB 9.12 MiB 991.34 KiB
ef2f368 8.15 MiB 9.10 MiB 965.24 KiB
6d317ea 8.15 MiB 9.12 MiB 986.26 KiB
1c6eb5b 8.15 MiB 9.12 MiB 986.27 KiB
322aa66 8.15 MiB 9.12 MiB 992.53 KiB
9c5aec6 8.15 MiB 9.12 MiB 986.23 KiB
56810ff 8.15 MiB 9.12 MiB 987.35 KiB
eecbbca 8.15 MiB 9.10 MiB 965.26 KiB
af2d175 8.15 MiB 9.12 MiB 986.22 KiB
3e5ee37 8.15 MiB 9.12 MiB 986.23 KiB

@marandaneto marandaneto changed the base branch from main to deps/flutter/scripts/update-android.sh/6.6.0 October 25, 2022 12:10
@marandaneto marandaneto marked this pull request as ready for review October 25, 2022 13:21
@marandaneto marandaneto merged commit a9ca181 into deps/flutter/scripts/update-android.sh/6.6.0 Oct 25, 2022
@marandaneto marandaneto deleted the feat/activity-frames-tracker-feature-flag branch October 25, 2022 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants