test: Remove clearTestState for ViewHierarchyTests #3940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SentryViewHierarchyTests only need to reset the SentryDependencyContainer and not reset the whole global test state.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3940 +/- ##
=============================================
- Coverage 90.663% 90.622% -0.042%
=============================================
Files 581 582 +1
Lines 45434 45523 +89
Branches 16169 16225 +56
=============================================
+ Hits 41192 41254 +62
- Misses 4172 4199 +27
Partials 70 70
... and 24 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
brustolin
reviewed
May 6, 2024
brustolin
approved these changes
May 8, 2024
philipphofmann
added a commit
that referenced
this pull request
May 10, 2024
The SentryViewHierarchyTests only need to reset the SentryDependencyContainer and not reset the whole global test state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SentryViewHierarchyTests only need to reset the SentryDependencyContainer and not reset the whole global test state.
#skip-changelog