Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Clarify FramesTracker log message #3570

Merged
merged 2 commits into from
Jan 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
### Fixes

- Move header reference out of "extern C" (#3538)
- Clarify FramesTracker log message (#3570)

## 8.19.0

Expand Down
4 changes: 2 additions & 2 deletions Sources/Sentry/SentryFramesTracker.m
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ - (void)displayLinkCallback
&& frameDuration <= SentryFrozenFrameThreshold) {
_slowFrames++;
# if SENTRY_TARGET_PROFILING_SUPPORTED
SENTRY_LOG_DEBUG(@"Capturing slow frame starting at %llu (frame tracker: %@).",
SENTRY_LOG_DEBUG(@"Detected slow frame starting at %llu (frame tracker: %@).",
thisFrameSystemTimestamp, self);
[self recordTimestamp:thisFrameSystemTimestamp
value:@(thisFrameSystemTimestamp - self.previousFrameSystemTimestamp)
Expand All @@ -173,7 +173,7 @@ - (void)displayLinkCallback
} else if (frameDuration > SentryFrozenFrameThreshold) {
_frozenFrames++;
# if SENTRY_TARGET_PROFILING_SUPPORTED
SENTRY_LOG_DEBUG(@"Capturing frozen frame starting at %llu.", thisFrameSystemTimestamp);
SENTRY_LOG_DEBUG(@"Detected frozen frame starting at %llu.", thisFrameSystemTimestamp);
[self recordTimestamp:thisFrameSystemTimestamp
value:@(thisFrameSystemTimestamp - self.previousFrameSystemTimestamp)
array:self.frozenFrameTimestamps];
Expand Down