fix: privacy manifest collection purposes type

[FelixHerrmann]

📜 Description

Change NSPrivacyCollectedDataTypePurposes type from string to array.

Note: Using the Property List representation of Xcode will use tabs instead of spaces under the hood, that's why the git diff is not super readable...

💡 Motivation and Context

We have started configuring the privacy manifest for our app. The generated Privacy Report from the Xcode Organizer presented us the following error:

Checking Sentry's manifest file confirmed it, the NSPrivacyCollectedDataTypePurposes (Collection Purposes) had the wrong type, string instead of array.

💚 How did you test it?

I haven't tested it by generating another report but Apple's docs clearly define it as an array of strings and the Xcode Property List representation shows the correction display names instead of the underlying key (Item 1 is fixed, Item 2 is original):

📝 Checklist

You have to check all boxes before merging:

• I reviewed the submitted code.
• I added tests to verify the changes.
• No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
• I updated the docs if needed.
• Review from the native team if needed.
• No breaking change or entry added to the changelog.
• No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

[codecov]

Codecov Report

Merging #3275 (0af9234) into main (881a955) will decrease coverage by 0.005%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##              main     #3275       +/-   ##
=============================================
- Coverage   89.223%   89.218%   -0.005%     
=============================================
  Files          501       502        +1     
  Lines        53949     54250      +301     
  Branches     19170     19453      +283     
=============================================
+ Hits         48135     48401      +266     
+ Misses        4958      4880       -78     
- Partials       856       969      +113     

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 881a955...0af9234. Read the comment docs.

[armcknight]

Thanks @FelixHerrmann for the fix! I pushed a changelog fix and let's see how CI does on that commit.

For easier diffing, here're the significant changes not including whitespace:

[FelixHerrmann]

For easier diffing, here're the significant changes not including whitespace:

Yes, much better to read, thanks for sending this!

[armcknight]

I'm going to close this one in favor of #3276, I think there's a permission error with the CI jobs on this one. Thanks again for the PR!

[FelixHerrmann]

All good, thanks for picking this up so quickly!

[FelixHerrmann]

I think there's a permission error with the CI jobs on this one.

@armcknight do you think thats a general issue or just with this particular PR? I have another small fix for you but I can also open an issue, let me know!

[armcknight]

I think it's because it's in a fork. If you push a branch directly to this remote for a PR, we should be able to authorize CI jobs containing sensitive info. Thanks for all your efforts @FelixHerrmann 🙏🏻

[FelixHerrmann]

Gotcha, will try next time! I just saw that the issue already got fixed in #3270, it's just not released yet 👍🏻