Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Mention attachScreenshot works for crashes #2620

Merged
merged 1 commit into from
Jan 18, 2023

Conversation

philipphofmann
Copy link
Member

Was forgotten to add in GH-1920.

#skip-changelog

@github-actions
Copy link

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1223.63 ms 1238.56 ms 14.93 ms
Size 20.76 KiB 414.44 KiB 393.68 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
443723a 1205.24 ms 1220.52 ms 15.28 ms
7c5d161 1224.38 ms 1249.66 ms 25.28 ms
56ec5d0 1236.65 ms 1261.90 ms 25.25 ms
56ec5d0 1194.39 ms 1236.94 ms 42.55 ms
feba2be 1246.67 ms 1254.64 ms 7.97 ms

App size

Revision Plain With Sentry Diff
443723a 20.76 KiB 414.44 KiB 393.68 KiB
7c5d161 20.76 KiB 414.44 KiB 393.68 KiB
56ec5d0 20.76 KiB 414.44 KiB 393.69 KiB
56ec5d0 20.76 KiB 414.44 KiB 393.68 KiB
feba2be 20.76 KiB 414.45 KiB 393.69 KiB

@codecov
Copy link

codecov bot commented Jan 17, 2023

Codecov Report

Merging #2620 (8906b7e) into main (56ec5d0) will increase coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2620      +/-   ##
==========================================
+ Coverage   79.82%   79.83%   +0.01%     
==========================================
  Files         243      243              
  Lines       22614    22615       +1     
  Branches    10010    10008       -2     
==========================================
+ Hits        18051    18055       +4     
- Misses       4112     4113       +1     
+ Partials      451      447       -4     
Impacted Files Coverage Δ
Sources/Sentry/include/SentryMachLogging.hpp 58.82% <0.00%> (-17.65%) ⬇️
Sources/Sentry/SentryMachLogging.cpp 0.00% <0.00%> (-3.02%) ⬇️
Sources/Sentry/SentryFileManager.m 95.04% <0.00%> (-0.42%) ⬇️
Sources/Sentry/SentrySerialization.m 87.84% <0.00%> (-0.13%) ⬇️
Sources/Sentry/SentryProfilingLogging.mm 51.85% <0.00%> (ø)
Sources/Sentry/include/SentryProfilingLogging.hpp 54.54% <0.00%> (ø)
Sources/Sentry/SentryNetworkTracker.m 95.27% <0.00%> (+0.06%) ⬆️
Sources/Sentry/SentryBacktrace.cpp 90.17% <0.00%> (+1.78%) ⬆️
Sources/Sentry/SentryThreadHandle.cpp 72.67% <0.00%> (+3.27%) ⬆️
Sources/Sentry/SentryThreadMetadataCache.cpp 95.65% <0.00%> (+4.34%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56ec5d0...8906b7e. Read the comment docs.

@philipphofmann philipphofmann merged commit 088f732 into main Jan 18, 2023
@philipphofmann philipphofmann deleted the ref/attach-screenshot-crashes branch January 18, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants