-
-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: Don't attach headers for SentryNoOpSpan #2498
Conversation
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
c6fb5a9 | 1194.80 ms | 1232.68 ms | 37.88 ms |
010583c | 1198.23 ms | 1225.52 ms | 27.29 ms |
a9e77dc | 1231.94 ms | 1254.85 ms | 22.91 ms |
f91714d | 1222.06 ms | 1247.00 ms | 24.94 ms |
d446105 | 1237.06 ms | 1261.34 ms | 24.28 ms |
2ae7db9 | 1231.37 ms | 1239.98 ms | 8.61 ms |
ffa889e | 1229.37 ms | 1253.38 ms | 24.01 ms |
8361c4c | 1204.07 ms | 1252.74 ms | 48.67 ms |
4dc66f6 | 1202.59 ms | 1228.34 ms | 25.75 ms |
9be1db2 | 1219.42 ms | 1245.66 ms | 26.24 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
c6fb5a9 | 20.75 KiB | 383.76 KiB | 363.01 KiB |
010583c | 20.75 KiB | 383.61 KiB | 362.85 KiB |
a9e77dc | 20.75 KiB | 379.12 KiB | 358.36 KiB |
f91714d | 20.75 KiB | 381.87 KiB | 361.12 KiB |
d446105 | 20.75 KiB | 383.37 KiB | 362.62 KiB |
2ae7db9 | 20.75 KiB | 381.87 KiB | 361.12 KiB |
ffa889e | 20.75 KiB | 383.83 KiB | 363.08 KiB |
8361c4c | 20.75 KiB | 383.87 KiB | 363.12 KiB |
4dc66f6 | 20.75 KiB | 381.81 KiB | 361.06 KiB |
9be1db2 | 20.75 KiB | 373.94 KiB | 353.19 KiB |
Previous results on branch: fix/2401-no-headers-NoOpSpan
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
9d980f4 | 1215.96 ms | 1241.36 ms | 25.40 ms |
bd20fde | 1226.45 ms | 1254.98 ms | 28.53 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
9d980f4 | 20.75 KiB | 404.86 KiB | 384.11 KiB |
bd20fde | 20.75 KiB | 404.82 KiB | 384.07 KiB |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 8.0.0 #2498 +/- ##
==========================================
- Coverage 78.44% 78.42% -0.02%
==========================================
Files 242 242
Lines 22282 22277 -5
Branches 9839 9834 -5
==========================================
- Hits 17479 17471 -8
- Misses 4351 4354 +3
Partials 452 452
Continue to review full report at Codecov.
|
Same here.
Quite annoying to have a red cross in the PR list, think a test failed, scroll through all the workflows hunting for the cross.. and then it's this thing. |
* 8.0.0: (31 commits) tests: Reenable testAddAndRemoveData (#2533) feat: support SENTRY_DSN environment var on macOS (#2534) Remove duplicate entry (#2532) fix: ARC issue for FileManager (#2525) feat: Add SwiftUI performance tracking (#2271) fix: Remove all permission checks (#2529) Remove the automatic `viewAppearing` span (#2511) Fix and reenable testANRDetected_UpdatesAppStateToTrue (#2526) fix: Don't add out of date context for crashes (#2523) ref: Rename isOOM to watchdog in Client (#2520) test: Fix disabled failing watchdog test (#2521) build(deps): bump github/codeql-action from 2.1.35 to 2.1.36 (#2516) Rename the watchdog option and integration (#2513) feat: Enable CaptureFailedRequests by default (#2507) test: Fix asserts for SentryCrashTestInstallation (#2500) meta: User interaction tracing enabled per default (#2506) ref: Rename OOM to Watchdog Terminations (#2499) feat: enableUserInteractionTracing is GA (#2503) build(deps): bump nokogiri from 1.13.9 to 1.13.10 (#2505) perf: Don't attach headers for SentryNoOpSpan (#2498) ...
📜 Description
Don't attach headers for SentryNoOpSpan. A small performance gain, but no other functional impact.
#skip-changelog
💡 Motivation and Context
Closes #2401.
💚 How did you test it?
Before I add tests, I'd like to know if this is indeed the correct way to go about this.
📝 Checklist
🔮 Next steps