-
-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Enhance the UIViewController breadcrumbs with more data #1945
Merged
Merged
Changes from 23 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
d4639f3
feat: Enhance the UIViewController breadcrumbs with more data
kevinrenskers 24ab320
Format code
getsentry-bot 87a13de
Add changelog
kevinrenskers 6ed0aac
Merge branch 'master' into feat/extra-controller-breadcrumb-data
kevinrenskers 8e4e078
Add a bunch more information
kevinrenskers 0424de7
Merge branch 'master' into feat/extra-controller-breadcrumb-data
kevinrenskers 480fe3f
Format code
getsentry-bot 17a3727
Add a few tests
kevinrenskers f11ddda
Make it build on macOS
kevinrenskers c2f2948
Remove the storyboard info, not very useful
kevinrenskers ce09f8c
Added more information and solved an iOS crash about unrecognised sel…
kevinrenskers 34717a7
Merge branch 'master' into feat/extra-controller-breadcrumb-data
kevinrenskers d4c35da
Format code
getsentry-bot cc4c5b0
Add some more tests
kevinrenskers d62cb92
Merge branch 'master' into feat/extra-controller-breadcrumb-data
kevinrenskers 773e10b
Add test for parentViewController
kevinrenskers d00e5b4
Added UI test: testBreadcrumbData
kevinrenskers 79682e2
Fix build error in iOS13-Swift
kevinrenskers 341eb5a
Merge branch 'master' into feat/extra-controller-breadcrumb-data
kevinrenskers 8d990e2
Remove unused import
kevinrenskers 476e262
Fix the test
kevinrenskers beee960
Merge branch 'master' into feat/extra-controller-breadcrumb-data
kevinrenskers aec148d
Different way of getting the breadcrumb data on screen
kevinrenskers 0df8b25
Remove force cast and force unwrap
kevinrenskers File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,3 @@ | ||
|
||
#import <Foundation/Foundation.h> | ||
|
||
NS_ASSUME_NONNULL_BEGIN | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding a UITest.