Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Track timezone changes as breadcrumbs #1930

Merged
merged 34 commits into from
Jul 6, 2022
Merged

feat: Track timezone changes as breadcrumbs #1930

merged 34 commits into from
Jul 6, 2022

Commits on Jul 4, 2022

  1. feat: Add automatic timezone change reporting as a breadcrumb

    @kevinrenskers
    kevinrenskers committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    cd2e0c0 View commit details
    Browse the repository at this point in the history

  2. Add a test for the new breadcrumb

    @kevinrenskers
    kevinrenskers committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    69c98c5 View commit details
    Browse the repository at this point in the history

  3. Format code

    @getsentry-bot
    getsentry-bot committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    b035930 View commit details
    Browse the repository at this point in the history

  4. Add changelog entry

    @kevinrenskers
    kevinrenskers committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    1434409 View commit details
    Browse the repository at this point in the history

  5. Indent with 4 spaces for all source files

    @kevinrenskers
    kevinrenskers committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    1ecd302 View commit details
    Browse the repository at this point in the history

  6. Fix testTimezoneChangeBreadcrumb by using the Swiftified name

    @kevinrenskers
    kevinrenskers committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    543bedb View commit details
    Browse the repository at this point in the history

  7. Actually fix the tests

    @kevinrenskers
    kevinrenskers committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    b90c52d View commit details
    Browse the repository at this point in the history

  8. Improve the start method's logic, prevent duplicate call in case of iOS

    @kevinrenskers
    kevinrenskers committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    4112017 View commit details
    Browse the repository at this point in the history

  9. Undo indentation change, it'll be in a separate PR

    @kevinrenskers
    kevinrenskers committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    ab971ed View commit details
    Browse the repository at this point in the history

  10. Merge branch 'master' into feat/timezone-change-breadcrumbs 

    * master:
  release: 7.19.0
    @kevinrenskers
    kevinrenskers committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    de3547d View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2022

  1. Feature complete, but test is flaky

    @kevinrenskers
    kevinrenskers committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    81102cc View commit details
    Browse the repository at this point in the history

  2. Format code

    @getsentry-bot
    getsentry-bot committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    4118523 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into feat/timezone-change-breadcrumbs 

    * master:
  build(deps): bump fastlane from 2.206.2 to 2.207.0 (#1937)
  fixing sample not compiling (#1935)
  style: Configure the root of the project to use four spaces for indentation (#1934)
  meta: Add LOGAF scale to Contributing (#1933)
  meta: Mention draft PRs in Contributing (#1932)
  meta: Add sut to contributing (#1931)
    @kevinrenskers
    kevinrenskers committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    57d86c1 View commit details
    Browse the repository at this point in the history

  4. timezoneOffset is nullable and shouldn't stop SentryAppState from bei… 

    …ng instantiated when it's missing on disk
    @kevinrenskers
    kevinrenskers committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    694ed71 View commit details
    Browse the repository at this point in the history

  5. Only run the code in iOS, because it doesn't compile for macOS 

    Provide a default value to deal with test crashes, until we can properly fix the tests
    @kevinrenskers
    kevinrenskers committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    9d5b0ac View commit details
    Browse the repository at this point in the history

  6. Format code

    @getsentry-bot
    getsentry-bot committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    82fe669 View commit details
    Browse the repository at this point in the history

  7. Deal with timezoneOffset == nil

    @kevinrenskers
    kevinrenskers committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    f453208 View commit details
    Browse the repository at this point in the history

  8. Commit first set of suggestions

    @kevinrenskers
    kevinrenskers committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    8d13cd4 View commit details
    Browse the repository at this point in the history

  9. Format code

    @getsentry-bot
    getsentry-bot committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    b83f59c View commit details
    Browse the repository at this point in the history

  10. Add more tests

    @kevinrenskers
    kevinrenskers committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    1a4f01e View commit details
    Browse the repository at this point in the history

  11. It works, but tests need to be fixed

    @kevinrenskers
    kevinrenskers committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    a0b6087 View commit details
    Browse the repository at this point in the history

  12. Format code

    @getsentry-bot
    getsentry-bot committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    cb42c7e View commit details
    Browse the repository at this point in the history

  13. Don't cache fileManager, as it can change when the hub changes

    @kevinrenskers
    kevinrenskers committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    6c7b428 View commit details
    Browse the repository at this point in the history

  14. Use currentDateProvider

    @kevinrenskers
    kevinrenskers committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    9f9e79a View commit details
    Browse the repository at this point in the history

  15. Format code

    @getsentry-bot
    getsentry-bot committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    c585e80 View commit details
    Browse the repository at this point in the history

  16. Undo

    @kevinrenskers
    kevinrenskers committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    f808338 View commit details
    Browse the repository at this point in the history

  17. Tests compile again

    @kevinrenskers
    kevinrenskers committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    4f7edd3 View commit details
    Browse the repository at this point in the history

  18. Fix warning

    @kevinrenskers
    kevinrenskers committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    97acf8d View commit details
    Browse the repository at this point in the history

  19. testTimezoneChangeBreadcrumb is still problematic

    @kevinrenskers
    kevinrenskers committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    bc9d991 View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2022

  1. Added more tests, and the whole suit runs successfully

    @kevinrenskers
    kevinrenskers committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    8ce9385 View commit details
    Browse the repository at this point in the history

  2. Format code

    @getsentry-bot
    getsentry-bot committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    70b982e View commit details
    Browse the repository at this point in the history

  3. Add more filemanager tests

    @kevinrenskers
    kevinrenskers committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    0ad0783 View commit details
    Browse the repository at this point in the history

  4. Format code

    @getsentry-bot
    getsentry-bot committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    0996314 View commit details
    Browse the repository at this point in the history

  5. One more test

    @kevinrenskers
    kevinrenskers committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    2571228 View commit details
    Browse the repository at this point in the history