Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Clarify FramesTracker log message #3570

Merged
merged 2 commits into from Jan 29, 2024

Conversation

philipphofmann
Copy link
Member

📜 Description

Change two log messages to state they detected a slow or frozen frame but not to capture them.

💡 Motivation and Context

Came up here getsentry/sentry-cli#1902 (comment).

Change two log messages to state they detected a slow or frozen frame
but not to capture them.
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5993516) 89.255% compared to head (42db834) 89.202%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #3570       +/-   ##
=============================================
- Coverage   89.255%   89.202%   -0.054%     
=============================================
  Files          529       529               
  Lines        57657     57707       +50     
  Branches     20630     20656       +26     
=============================================
+ Hits         51462     51476       +14     
- Misses        5287      5317       +30     
- Partials       908       914        +6     
Files Coverage Δ
Sources/Sentry/SentryFramesTracker.m 100.000% <100.000%> (ø)

... and 19 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5993516...42db834. Read the comment docs.

Copy link

github-actions bot commented Jan 23, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1232.98 ms 1256.76 ms 23.78 ms
Size 21.58 KiB 417.88 KiB 396.30 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
e324230 1244.43 ms 1252.98 ms 8.55 ms
d760c3f 1200.95 ms 1233.96 ms 33.00 ms
5d6ce0e 1227.57 ms 1241.08 ms 13.51 ms
7cd187e 1223.41 ms 1249.40 ms 26.00 ms
407ff99 1216.63 ms 1235.50 ms 18.87 ms
dc0db9e 1246.06 ms 1260.46 ms 14.40 ms
881a955 1230.98 ms 1246.22 ms 15.24 ms
98cca71 1210.75 ms 1240.64 ms 29.89 ms
9faf217 1268.86 ms 1274.82 ms 5.96 ms
e1eed6b 1224.63 ms 1234.84 ms 10.20 ms

App size

Revision Plain With Sentry Diff
e324230 22.85 KiB 408.88 KiB 386.03 KiB
d760c3f 22.84 KiB 403.17 KiB 380.33 KiB
5d6ce0e 22.85 KiB 405.38 KiB 382.53 KiB
7cd187e 20.76 KiB 401.66 KiB 380.89 KiB
407ff99 20.76 KiB 427.87 KiB 407.10 KiB
dc0db9e 20.76 KiB 419.62 KiB 398.86 KiB
881a955 22.85 KiB 407.63 KiB 384.79 KiB
98cca71 22.85 KiB 411.14 KiB 388.29 KiB
9faf217 20.76 KiB 419.70 KiB 398.94 KiB
e1eed6b 20.76 KiB 432.17 KiB 411.41 KiB

Previous results on branch: fix/frames-tracker-log-message

Startup times

Revision Plain With Sentry Diff
c8f7b15 1205.31 ms 1222.59 ms 17.29 ms

App size

Revision Plain With Sentry Diff
c8f7b15 21.58 KiB 417.90 KiB 396.32 KiB

@philipphofmann philipphofmann merged commit 89491ad into main Jan 29, 2024
31 of 33 checks passed
@philipphofmann philipphofmann deleted the fix/frames-tracker-log-message branch January 29, 2024 08:22
Copy link

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Clarify FramesTracker log message ([#3570](https://github.com/getsentry/sentry-cocoa/pull/3570))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 989051b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants