Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change NSPrivacyCollectedDataTypePurposes type from string to array #3276

Merged

Conversation

armcknight
Copy link
Member

@armcknight armcknight commented Sep 11, 2023

from #3275, it looked like the jobs might be failing because they can't clone the codesign repo?

@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Merging #3276 (cac0e02) into main (881a955) will increase coverage by 0.008%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #3276       +/-   ##
=============================================
+ Coverage   89.223%   89.231%   +0.008%     
=============================================
  Files          501       502        +1     
  Lines        53949     54277      +328     
  Branches     19170     19487      +317     
=============================================
+ Hits         48135     48432      +297     
- Misses        4958      4988       +30     
- Partials       856       857        +1     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 881a955...cac0e02. Read the comment docs.

@github-actions
Copy link

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1208.24 ms 1227.76 ms 19.51 ms
Size 22.85 KiB 407.62 KiB 384.77 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
6e342ac 1202.98 ms 1228.74 ms 25.76 ms
46f5eb8 1200.09 ms 1231.38 ms 31.29 ms
33b2f51 1219.29 ms 1240.24 ms 20.95 ms
fc163f5 1198.05 ms 1227.76 ms 29.71 ms
84fb4d9 1237.76 ms 1255.46 ms 17.70 ms
66922ca 1221.68 ms 1235.98 ms 14.30 ms
8c50edb 1212.98 ms 1233.72 ms 20.74 ms
f938d24 1223.26 ms 1242.12 ms 18.86 ms
c76f9b0 1249.78 ms 1265.14 ms 15.36 ms
e71cf92 1201.69 ms 1226.52 ms 24.83 ms

App size

Revision Plain With Sentry Diff
6e342ac 20.76 KiB 436.66 KiB 415.90 KiB
46f5eb8 20.76 KiB 432.37 KiB 411.61 KiB
33b2f51 20.76 KiB 432.17 KiB 411.41 KiB
fc163f5 20.76 KiB 436.30 KiB 415.54 KiB
84fb4d9 22.84 KiB 402.57 KiB 379.72 KiB
66922ca 20.76 KiB 425.80 KiB 405.04 KiB
8c50edb 20.76 KiB 432.31 KiB 411.55 KiB
f938d24 20.76 KiB 434.88 KiB 414.12 KiB
c76f9b0 22.85 KiB 406.69 KiB 383.84 KiB
e71cf92 20.76 KiB 419.85 KiB 399.10 KiB

@github-actions
Copy link

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1236.65 ms 1249.12 ms 12.47 ms
Size 22.85 KiB 407.61 KiB 384.76 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
6e342ac 1202.98 ms 1228.74 ms 25.76 ms
46f5eb8 1200.09 ms 1231.38 ms 31.29 ms
33b2f51 1219.29 ms 1240.24 ms 20.95 ms
fc163f5 1198.05 ms 1227.76 ms 29.71 ms
84fb4d9 1237.76 ms 1255.46 ms 17.70 ms
66922ca 1221.68 ms 1235.98 ms 14.30 ms
8c50edb 1212.98 ms 1233.72 ms 20.74 ms
f938d24 1223.26 ms 1242.12 ms 18.86 ms
c76f9b0 1249.78 ms 1265.14 ms 15.36 ms
e71cf92 1201.69 ms 1226.52 ms 24.83 ms

App size

Revision Plain With Sentry Diff
6e342ac 20.76 KiB 436.66 KiB 415.90 KiB
46f5eb8 20.76 KiB 432.37 KiB 411.61 KiB
33b2f51 20.76 KiB 432.17 KiB 411.41 KiB
fc163f5 20.76 KiB 436.30 KiB 415.54 KiB
84fb4d9 22.84 KiB 402.57 KiB 379.72 KiB
66922ca 20.76 KiB 425.80 KiB 405.04 KiB
8c50edb 20.76 KiB 432.31 KiB 411.55 KiB
f938d24 20.76 KiB 434.88 KiB 414.12 KiB
c76f9b0 22.85 KiB 406.69 KiB 383.84 KiB
e71cf92 20.76 KiB 419.85 KiB 399.10 KiB

@brustolin brustolin merged commit e758449 into main Sep 18, 2023
67 checks passed
@brustolin brustolin deleted the armcknight/fix/privacy-manifest-collection-purposes-type branch September 18, 2023 08:30
airtelshivam pushed a commit to airtelshivam/sentry-cocoa that referenced this pull request Apr 12, 2024
…ray (getsentry#3276)

* Change NSPrivacyCollectedDataTypePurposes type from string to array

* changelog

* Update CHANGELOG.md

---------

Co-authored-by: Felix Herrmann <felix.herrmann@icloud.com>
(cherry picked from commit e758449)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants