Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove warning about non-portable path to file "SentryDsn.h" #3270

Merged
merged 4 commits into from Sep 6, 2023

Conversation

brustolin
Copy link
Contributor

馃摐 Description

馃挕 Motivation and Context

closes #3269

馃挌 How did you test it?

Manually

馃摑 Checklist

You have to check all boxes before merging:

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

馃敭 Next steps

@github-actions
Copy link

github-actions bot commented Sep 6, 2023

Performance metrics 馃殌

Plain With Sentry Diff
Startup time 1210.73 ms 1225.59 ms 14.86 ms
Size 22.85 KiB 407.64 KiB 384.79 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
adcc7d8 1225.90 ms 1245.08 ms 19.18 ms
25737cb 1235.02 ms 1250.06 ms 15.04 ms
32e64d1 1249.42 ms 1264.76 ms 15.34 ms
aa27ac0 1214.02 ms 1227.42 ms 13.40 ms
c2ec420 1256.27 ms 1269.24 ms 12.97 ms
6943de0 1237.67 ms 1247.12 ms 9.45 ms
c0b4b71 1246.98 ms 1256.77 ms 9.79 ms
0ffe199 1209.51 ms 1223.94 ms 14.43 ms
e8b2fb4 1230.70 ms 1242.84 ms 12.14 ms
368187c 1220.00 ms 1247.12 ms 27.12 ms

App size

Revision Plain With Sentry Diff
adcc7d8 20.76 KiB 426.15 KiB 405.39 KiB
25737cb 20.76 KiB 436.29 KiB 415.53 KiB
32e64d1 20.76 KiB 433.18 KiB 412.42 KiB
aa27ac0 20.76 KiB 432.21 KiB 411.45 KiB
c2ec420 20.76 KiB 401.65 KiB 380.89 KiB
6943de0 20.76 KiB 393.33 KiB 372.57 KiB
c0b4b71 20.76 KiB 430.98 KiB 410.22 KiB
0ffe199 20.76 KiB 436.50 KiB 415.74 KiB
e8b2fb4 20.76 KiB 427.23 KiB 406.46 KiB
368187c 20.76 KiB 436.50 KiB 415.74 KiB

Previous results on branch: fix/dsn-header

Startup times

Revision Plain With Sentry Diff
7dc4fe7 1244.10 ms 1260.71 ms 16.61 ms
3112e59 1254.50 ms 1268.76 ms 14.26 ms

App size

Revision Plain With Sentry Diff
7dc4fe7 22.85 KiB 407.63 KiB 384.78 KiB
3112e59 22.85 KiB 407.63 KiB 384.78 KiB

CHANGELOG.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #3270 (8d7dd68) into main (d61b939) will decrease coverage by 0.008%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #3270       +/-   ##
=============================================
- Coverage   89.213%   89.205%   -0.008%     
=============================================
  Files          502       502               
  Lines        54291     54243       -48     
  Branches     19491     19474       -17     
=============================================
- Hits         48435     48388       -47     
+ Misses        4887      4884        -3     
- Partials       969       971        +2     
Files Changed Coverage
Sources/Sentry/SentryPropagationContext.m

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update d61b939...8d7dd68. Read the comment docs.

@brustolin brustolin merged commit 881a955 into main Sep 6, 2023
66 of 67 checks passed
@brustolin brustolin deleted the fix/dsn-header branch September 6, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning: non-portable path to file '"SentryDsn.h"'
2 participants