fix: Remove logging that could occur while a thread is suspended #2014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
indragiek
requested review from
philipphofmann,
brustolin and
armcknight
as code owners
armcknight
approved these changes
Jul 28, 2022
| return SENTRY_PROF_LOG_KERN_RETURN(thread_suspend(handle_)) == KERN_SUCCESS; | ||
| return thread_suspend(handle_) == KERN_SUCCESS; |
There was a problem hiding this comment.
We could eventually store the errno and log it after resuming the thread as well.
brustolin
approved these changes
Jul 28, 2022
kevinrenskers
added a commit
that referenced
this pull request
Aug 1, 2022
* master: ci: benchmarking and profile generation improvements (#2022) release: 7.23.0 fix: Bad merge on CHANGELOG.md (#2020) fix: Log empty samples instead of collecting stacks for idle threads (#2013) fix: Handle failure to read thread priority gracefully (#2015) fix: Remove logging that could occur while a thread is suspended (#2014) fix: Use constant for max thread name size instead of magic number (#2012) Disable flaky tesDefaultMaxEnvelopesConcurrent (#2018) Fix build failure in unit tests (#2019) Fix address sanitizer compilation error (#1996) fix: Sauce labs iPhone 13 pro iOS version feat: Add transaction to baggage and trace headers (#1992) ci: fix ui thread starvation in benchmarks (#2009) fix: Add more descriptive deprecation message for enableProfiling (#2011) feat: Add sampling configuration for profiling (#2004) fix log message option name (#2006) meta: add armcknight as a codeowner (#2008) release: 7.22.0 fix: Disable broken LaunchUITests to unblock release (#2003) # Conflicts: # Samples/iOS-Swift/iOS-Swift/ViewControllers/PerformanceViewController.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃摐 Description
Remove some logging that could happen when threads fail to be suspended or resumed.
馃挕 Motivation and Context
SENTRY_PROF_LOG_KERN_RETURNwill result in a call to a logger that may perform a heap allocation, which is dangerous for the reasons documented here:sentry-cocoa/Sources/Sentry/SentryBacktrace.cpp
Line 127 in 91cf82a
This is an unlikely scenario - if the thread_suspend call fails and we log an error, the thread is likely not suspended - but the logs are low value enough that it's better not to take the risk.
馃挌 How did you test it?
This is preventing a hard-to-reproduce scenario so there's no way to easily unit test it, but we check that all existing tests pass.
馃摑 Checklist
馃敭 Next steps