Skip to content

Commit

Permalink
fix: Remove logging that could occur while a thread is suspended (#2014)
Browse files Browse the repository at this point in the history
Remove some logging that could happen when threads fail to be suspended or resumed.

Co-authored-by: Philipp Hofmann <philipp.hofmann@sentry.io>
  • Loading branch information
indragiek and philipphofmann committed Jul 28, 2022
1 parent 3fc26db commit 3b70b5b
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@

- Add sampling configuration for profiling (#2004)

### Fixes

- Remove logging that could occur while a thread is suspended (#2014)

## 7.22.0

### Features
Expand Down
4 changes: 2 additions & 2 deletions Sources/Sentry/SentryThreadHandle.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ namespace profiling {
if (handle_ == THREAD_NULL) {
return false;
}
return SENTRY_PROF_LOG_KERN_RETURN(thread_suspend(handle_)) == KERN_SUCCESS;
return thread_suspend(handle_) == KERN_SUCCESS;
}

bool
Expand All @@ -249,7 +249,7 @@ namespace profiling {
if (handle_ == THREAD_NULL) {
return false;
}
return SENTRY_PROF_LOG_KERN_RETURN(thread_resume(handle_)) == KERN_SUCCESS;
return thread_resume(handle_) == KERN_SUCCESS;
}

bool
Expand Down

0 comments on commit 3b70b5b

Please sign in to comment.