build(python): Stop building Python package #1972
Conversation
| @@ -167,49 +167,6 @@ jobs: | |||
| name: ${{ github.sha }} | |||
| path: '*.tgz' | |||
|
|
|||
| python-base: | |||
There was a problem hiding this comment.
sentry and getsentry are using this -- could you please restore the python package?
There was a problem hiding this comment.
@asottile-sentry Craft fails whenever we attempt to release the Python package (see #1938). I think we tried upgrading the Debian version we use in Craft to fix this, but that broke something else (JS releases, I think).
There was a problem hiding this comment.
I was unaware though that we use the Python package in sentry and getsentry – we should probably prioritize looking into coming up with a fix in Craft then so we can start making Python releases
There was a problem hiding this comment.
I believe @vaind found the cause of the node20 upgrade breaking things -- but looks like they didn't push through with fixing it getsentry/craft#518
There was a problem hiding this comment.
@asottile-sentry Making sure I understood correctly: based on your comment, it sounds like we know the cause of the problem but it is not fixed yet, correct? I am confused because the issue you linked is closed.
Should I open a new issue in Craft about Sentry CLI Python releases being broken, or should we just reopen the getsentry/craft#518 and perhaps add a comment to mention that the issue is blocking Python releases?
|
That's sad. Did you consider external retry logic like pypa/twine#1017 (comment) this one? |
|
Based on @asottile-sentry's comment above, we are going to try reenabling Python package releases |
|
@asottile-sentry @doc-sheet, looks like Python releases are working again after #1980! |
We no longer release a Python package (see #1938 and #1779) because attempting to release for Python caused the release to fail.
However, I noticed that we are still building a Python package, which seems pointless since we don't release the Python package anywhere.
This PR disables Python package builds, and also deletes files that were only needed for the Python builds/packaging. If we ever re-enable Python releases, we would need to revert this PR.