fix: move dist option to SentryCliUploadSourceMapsOptions #1269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamilogorek
approved these changes
Jul 5, 2022
|
Uff, my bad. Thanks for the fix. Funny enough, we had it merged somewhat incorrectly in webpack plugin, so it works there just fine 👀
|
|
Yeah, it seems that in webpack plugin they passing the whole options object to uploadSourcemap method, while in vite plugin we keep settings splitted for sentry-cli submodules for sourcemaps, deploy and setCommits using sentry-cli types mostly:) |
lforst
added a commit
to robertcepa/sentry-javascript-bundler-plugins
that referenced
this pull request
Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
It seems that the
distis wrongly placed at main settings, while (according to this sourcecode) it need to be placed in source maps settings (passing dist option to new SentryCli(path, opts) doesnt do anything, while passing it to uploadSourceMaps works).This PR moves
distfromSentryCliOptionstoSentryCliUploadSourceMapsOptions