Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to set dist #20

Closed
OrbisK opened this issue Jul 4, 2022 · 4 comments
Closed

How to set dist #20

OrbisK opened this issue Jul 4, 2022 · 4 comments

Comments

@OrbisK
Copy link

OrbisK commented Jul 4, 2022

image

Currently I am missing the ability to set the dist: https://docs.sentry.io/product/cli/releases/#sentry-cli-sourcemaps (see option --dist)

@ikenfin
Copy link
Owner

ikenfin commented Jul 4, 2022

@OrbisK hi! I will look to add this option to plugin asap!

@ikenfin
Copy link
Owner

ikenfin commented Jul 4, 2022

Seems you can use dist already (place it at sourceMaps config object).

I think sentry team accidentialy placed dist option to the top level, while this is source map uploader option (https://github.com/getsentry/sentry-cli/blob/master/js/releases/options/uploadSourcemaps.js#L10).

I have published patched types in git repo, also will make PR to sentry-cli

@OrbisK
Copy link
Author

OrbisK commented Jul 4, 2022

Just for reference: getsentry/sentry-cli#1269

@ikenfin
Copy link
Owner

ikenfin commented Jul 8, 2022

Sentry/cli released new version fixing the issue, i've just published v1.1.1 that uses updated types👍

@ikenfin ikenfin closed this as completed Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants