Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misleading auth-token error message in case "sentry-cli info" fails #708

Merged
merged 7 commits into from
May 16, 2024

Conversation

markushi
Copy link
Member

馃摐 Description

Telemetry uses sentry-cli info to gather some env setup information. However, if no auth token is present the stderr is printed and shown as an error in IDEs like Android Studio.

As it can be fine for sentry-cli info to fail, simply swallow and re-print the std err and fallback to a default config.

馃挌 How did you test it?

馃摑 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

馃敭 Next steps

@markushi markushi changed the title Fix add fallback in case "sentry-cli info" fails Fix misleading auth-token error message in case "sentry-cli info" fails May 15, 2024
Copy link
Member

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, not sure if we need a test for this, but it's also fine without

@markushi markushi merged commit 0399750 into main May 16, 2024
18 checks passed
@markushi markushi deleted the fix/sentry-cli-usage branch May 16, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants