Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude BuildConfig sources from source bundles #705

Merged
merged 5 commits into from May 16, 2024
Merged

Exclude BuildConfig sources from source bundles #705

merged 5 commits into from May 16, 2024

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented May 8, 2024

馃摐 Description

  • Exclude sources that contain build config in their path (considering well-known community plugins for buildConfig generation as well)

馃挕 Motivation and Context

Closes #692
Closes #683

馃挌 How did you test it?

Manually verified with the sample from #692 + also automated test

馃摑 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

markushi
markushi approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

@romtsn romtsn merged commit acf36f3 into main May 16, 2024
18 checks passed
@romtsn romtsn deleted the rz/fix/source-context-buildconfig branch May 16, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markushi markushi markushi approved these changes

@adinauer adinauer Awaiting requested review from adinauer adinauer is a code owner

@stefanosiano stefanosiano Awaiting requested review from stefanosiano stefanosiano is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Uploading source context build failure Configuration Cache Incompatibility
2 participants
@romtsn @markushi