Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Okhttp-integration version check #327

Merged
merged 6 commits into from Jun 14, 2022
Merged

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Jun 14, 2022

馃摐 Description

If the auto-installation feature is disabled, okhttp instrumentation would crash the app (if there were no okhttp integration on the classpath), because we were checking for the wrong dependency (sentry-android-core instead of sentry-android-okhttp).

Now we just collect all the io.sentry dependencies and persists them in a map to later check for the respective module version when selecting instrumentables.

馃挕 Motivation and Context

Closes #326

馃挌 How did you test it?

Manually and unit + integration tests

馃摑 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

馃敭 Next steps

@romtsn romtsn requested a review from marandaneto as a code owner June 14, 2022 09:14
CHANGELOG.md Outdated Show resolved Hide resolved
@romtsn romtsn force-pushed the fix/okhttp-integration-check branch from 7ae3a66 to 61dbe7d Compare June 14, 2022 15:37
@romtsn romtsn merged commit 04303e1 into main Jun 14, 2022
@romtsn romtsn deleted the fix/okhttp-integration-check branch June 14, 2022 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug with OkHttp instrumentation
3 participants