Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sentry-android runtime SDK version #321

Merged
merged 9 commits into from Jun 14, 2022

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Jun 9, 2022

No description provided.

@romtsn romtsn requested a review from marandaneto as a code owner June 9, 2022 13:11
@marandaneto
Copy link
Contributor

  • There are a few tests failing with AGP 7.3 and 7.4.
  • MIssing changelog.
  • We have to change this test to not account for the number 4 but rather checking its > 0 most likely, since there are new samples, more symbols are generated and it fails.

@romtsn
Copy link
Member Author

romtsn commented Jun 13, 2022

So I believe I'm hitting a bug in R8 (which only happens in AGP 7.3.0-betaX and 7.4.0-alphaX, since they use a newer version of R8). I've filed it here - https://issuetracker.google.com/issues/235733922. It's related to 6.0.0 proguard-rules.

Wdyt we should do in the meantime? There's a workaround I found (needs a new release of sentry-android), or we can disable AGP beta/alpha tests for now, and force release a new version of SAGP.

CHANGELOG.md Outdated Show resolved Hide resolved
@marandaneto
Copy link
Contributor

So I believe I'm hitting a bug in R8 (which only happens in AGP 7.3.0-betaX and 7.4.0-alphaX, since they use a newer version of R8). I've filed it here - issuetracker.google.com/issues/235733922. It's related to 6.0.0 proguard-rules.

Wdyt we should do in the meantime? There's a workaround I found (needs a new release of sentry-android), or we can disable AGP beta/alpha tests for now, and force release a new version of SAGP.

What would be the fix on sentry-android? It seems that we should fix it on our end since we can't guarantee a fast response on the AGP side.

@romtsn
Copy link
Member Author

romtsn commented Jun 13, 2022

Add this to proguard rules:

-keepclassmembers enum io.sentry.** { *; }

Co-authored-by: Manoel Aranda Neto <5731772+marandaneto@users.noreply.github.com>
@marandaneto
Copy link
Contributor

Add this to proguard rules:

-keepclassmembers enum io.sentry.** { *; }

Since there are just a few enums (~10), I'd be fine with it for now.

@romtsn romtsn merged commit e320dc4 into main Jun 14, 2022
@romtsn romtsn deleted the chore/bump-runtime-sdk-version branch June 14, 2022 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants