Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enha: sentry-cli Integration Tests #371

Merged
merged 9 commits into from Sep 5, 2022
Merged

Conversation

denrase
Copy link
Collaborator

@denrase denrase commented Aug 25, 2022

#skip-changelog

馃摐 Description

Adds integration tests to the repository for the sentry-cli commands used by this plugin.

Run locally:

test/integration-test-server-start.sh

In separate process:

export ANDROID_HOME=~/Library/Android/sdk/
export SENTRY_URL=http://127.0.0.1:8000
./gradlew -p plugin-build test --tests SentryPluginIntegrationTest
test/integration-test-server-stop.sh

馃挕 Motivation and Context

  • We want to make sure that the bundled sentry-cli version can run the used commands without issue.
  • This is still very much a work in progress, as it is not clear yet how to best run there tests on CI

馃摑 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

馃敭 Next steps

  • Run test with CI

@adinauer
Copy link
Member

adinauer commented Sep 1, 2022

@marandaneto do you also want to give this a review or can I just merge it?

@marandaneto
Copy link
Contributor

@marandaneto do you also want to give this a review or can I just merge it?

Feel free to merge it when there's one approval.

Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @denrase

@denrase denrase merged commit d1a2011 into main Sep 5, 2022
@denrase denrase deleted the enha/sentry-cli-integration-tests branch September 5, 2022 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants