Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use docker-compose 2.7.0 instead of 2.2.3 in CI #1591

Merged
merged 4 commits into from Aug 17, 2022

Conversation

aminvakil
Copy link
Collaborator

Then I'm going to implement #1294 (comment), but first this needs to be merged.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@aminvakil aminvakil changed the title Use docker-compose 2.7.0 instead of 2.2.3 Use docker-compose 2.7.0 instead of 2.2.3 in CI Jul 24, 2022
Copy link
Contributor

@ethanhs ethanhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this!

@ethanhs ethanhs closed this Jul 27, 2022
@ethanhs ethanhs reopened this Jul 27, 2022
@ethanhs
Copy link
Contributor

ethanhs commented Jul 27, 2022

Closing/reopening because the integration tests seemed stalled.

@aminvakil
Copy link
Collaborator Author

Closing/reopening because the integration tests seemed stalled.

I think the stalled test is because it has been changed, and is a github bug.

We don't need to run our test on 2.2.3 .

@aminvakil
Copy link
Collaborator Author

https://github.com/docker/compose/releases/tag/v2.8.0 has been released, do we want to bump to 2.8.0 instead of 2.7.0?

@ethanhs
Copy link
Contributor

ethanhs commented Aug 1, 2022

https://github.com/docker/compose/releases/tag/v2.8.0 has been released, do we want to bump to 2.8.0 instead of 2.7.0?

I think that is fine! The goal is to use a newer compose, right?

@aminvakil
Copy link
Collaborator Author

https://github.com/docker/compose/releases/tag/v2.9.0 has just been released :)

@aminvakil aminvakil changed the title Use docker-compose 2.7.0 instead of 2.2.3 in CI Use docker-compose 2.9.0 instead of 2.2.3 in CI Aug 1, 2022
@BYK
Copy link
Collaborator

BYK commented Aug 1, 2022

Maybe we should schedule a daily cron job to update the version :P

@ethanhs
Copy link
Contributor

ethanhs commented Aug 1, 2022

Alright hopefully they don't release another before CI finishes, but once CI is finished I will merge this :)

Should we remove the integration test that we seem not use anymore?

@aminvakil
Copy link
Collaborator Author

  Notice: 01 17:05:36 [notice] 24#24: signal process started
  docker: Error response from daemon: network self-hosted-1_default not found.
  An error occurred, caught SIGERR on line 9
  *NOT* cleaning up, to clean your environment run "docker compose stop".

Seems like we're facing new problems 😢
Closing and reopening to trigger CI.

@aminvakil aminvakil closed this Aug 2, 2022
@aminvakil aminvakil reopened this Aug 2, 2022
@aminvakil
Copy link
Collaborator Author

Alright hopefully they don't release another before CI finishes, but once CI is finished I will merge this :)

Should we remove the integration test that we seem not use anymore?

I think it will be removed once this is merged, we will see on #1600 then.

@aminvakil
Copy link
Collaborator Author

Yes, we're facing new problems 😭

  Notice: 02 09:23:18 [notice] 24#24: signal process started
  docker: Error response from daemon: network self-hosted-1_default not found.
  time="2022-08-02T09:23:18Z" level=error msg="error waiting for container: context canceled"
  An error occurred, caught SIGERR on line 9
  *NOT* cleaning up, to clean your environment run "docker compose stop".

Trying docker-compose 2.8.0 now.

@aminvakil
Copy link
Collaborator Author

  Error response from daemon: Conflict. The container name "/sentry-self-hosted-snuba-cleanup-1" is already in use by container "6fd4b47b6c33bb1cb997b6bdb8041a7f052f5e329fa27d907066333a987a8389". You have to remove (or rename) that container to be able to reuse that name.

@aminvakil aminvakil closed this Aug 2, 2022
@aminvakil aminvakil reopened this Aug 2, 2022
@aminvakil
Copy link
Collaborator Author

  Notice: 02 10:11:40 [notice] 24#24: signal process started
  docker: Error response from daemon: network self-hosted-1_default not found.
  time="2022-08-02T10:11:40Z" level=error msg="error waiting for container: context canceled"
  An error occurred, caught SIGERR on line 9
  *NOT* cleaning up, to clean your environment run "docker compose stop".
  Error: Process completed with exit code 125.

on docker-compose 2.8.0 too.

I've seen something like this on our instance too one time with docker-compose 2.8.0 .

From https://github.com/docker/compose/releases/tag/v2.8.0:

This release introduced a breaking change via compose-go v1.3.0 and this compose-spec/compose-go#294.
Docker Compose will recreate new resources (networks, volumes, secrets, configs...) with new names, using a - instead a _ and try to connect/use to this new created resources instead of your existing ones!
Please use Compose v2.9.0 instead

But still it seems like both 2.8.0 and 2.9.0 got problems.

@aminvakil aminvakil changed the title Use docker-compose 2.9.0 instead of 2.2.3 in CI Use docker-compose 2.7.0 instead of 2.2.3 in CI Aug 2, 2022
@ethanhs ethanhs merged commit 081239e into getsentry:master Aug 17, 2022
@ethanhs
Copy link
Contributor

ethanhs commented Aug 17, 2022

Thanks for changing this!

@aminvakil aminvakil deleted the docker_compose2.7.0 branch August 21, 2022 13:44
@github-actions github-actions bot locked and limited conversation to collaborators Sep 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants