Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mypy namespace package issue #560

Merged
merged 3 commits into from Jun 28, 2022

Conversation

beliaev-maksim
Copy link
Collaborator

closes #556

mypy patcher complaints on namespace packages
@codecov
Copy link

codecov bot commented Jun 22, 2022

Codecov Report

Merging #560 (ed1a39c) into master (72c67ba) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #560   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines         2607      2607           
=========================================
  Hits          2607      2607           
Impacted Files Coverage Δ
responses/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72c67ba...ed1a39c. Read the comment docs.

exclude mock package data from reqs
@markstory markstory merged commit c15aa4e into getsentry:master Jun 28, 2022
@markstory
Copy link
Member

Nice work 👏

@beliaev-maksim
Copy link
Collaborator Author

@markstory
thanks!

@beliaev-maksim beliaev-maksim deleted the mbeliaev/mypy branch June 28, 2022 14:06
@hauntsaninja hauntsaninja mentioned this pull request Feb 6, 2023
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

responses 0.21.0 broke mypy check
2 participants