Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed internal _cookies_from_headers function #512

Merged
merged 4 commits into from Mar 21, 2022

Conversation

beliaev-maksim
Copy link
Collaborator

Note: merge after #497 due to the potential merge conflict

@codecov
Copy link

codecov bot commented Mar 11, 2022

Codecov Report

Merging #512 (571d3b1) into master (e907b4b) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #512   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines         2315      2299   -16     
=========================================
- Hits          2315      2299   -16     
Impacted Files Coverage Δ
responses/__init__.py 100.00% <ø> (ø)
responses/tests/test_responses.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e907b4b...571d3b1. Read the comment docs.

@markstory
Copy link
Member

Going to hold off on this until 0.21.0 as 0.19 was a bit bumpy and I'd like to get the fixes out for folks using moto.

@beliaev-maksim
Copy link
Collaborator Author

@bblommers
just to double check, don't you rely on this functionality?

@bblommers
Copy link
Contributor

No, we don't use this particular field @beliaev-maksim - thanks for asking!

@markstory markstory merged commit 41b1198 into getsentry:master Mar 21, 2022
@beliaev-maksim beliaev-maksim deleted the mbeliaev/clean branch March 21, 2022 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants