fix 468 #469
Merged
fix 468 #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #469 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 2012 2012
=========================================
Hits 2012 2012 Continue to review full report at Codecov.
|
adamtheturtle
added a commit
to adamtheturtle/requests-mock-flask
that referenced
this pull request
Jan 22, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #468
Issue is caused by new behavior of decorator, which allows to run it as static
responses.activateas well as a function call likeresponses.activate(registries=).mypycannot treat it really well. See pydantic/pydantic#2052In order to avoid this, we will need to overload decorator definition in typing.