fix(breakdown): Account root span in span op breakdown #1213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashed
force-pushed
the
breakdowns/use-root-span-for-op-breakdowns
branch
from
586a6ac
to
8dfb47d
Compare
|
CI lint job is failing due to psf/black#2966. |
untitaker
approved these changes
Mar 29, 2022
| let spans = match event.spans.value() { | ||
| None => return None, | ||
| Some(spans) => spans, | ||
| let mut spans = match event.spans.value() { |
There was a problem hiding this comment.
instead of allocating a new vector here, can you extract the loop body into a function, and call it for each entry in event.spans + the root span?
| @@ -82,6 +84,37 @@ fn get_op_time_spent(mut intervals: Vec<TimeWindowSpan>) -> Option<f64> { | |||
| Some(op_time_spent) | |||
| } | |||
|
|
|||
| fn span_from_trace_context(event: &Event) -> Option<Annotated<Span>> { | |||
There was a problem hiding this comment.
Instead of doing this I would create a trait that abstracts over spans and trace contexts, called SpanLike. That's probably useful across the codebase.
Main reason is re-allocation of strings
dashed
force-pushed
the
breakdowns/use-root-span-for-op-breakdowns
branch
from
4d51c3d
to
0539f79
Compare
untitaker
requested changes
Mar 31, 2022
|
@dashed could you give the requested changes a look and update or close this PR? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #1212.
For span operation breakdowns, we should account for the root span. The root span was intentionally omitted during the initial breakdown implementation, since it would've "blow up" the
span.total.timefield. This was reflected on the client-side implementation of the span operation breakdowns for the span view; of which the breakdown implementation in Relay was based upon.We can do this today since the
span.total.timefield is currently un-used in the product today. Its usage in the product was removed in: